Added board detection for UDOO Bolt using check_board_asset_value() #81
Conversation
…nd added it to detect.py
adafruit_platformdetect/board.py
Outdated
| @@ -117,7 +118,7 @@ def id(self): | |||
| board_id = self._clockwork_pi_id() | |||
| elif chip_id == chips.RK3308: | |||
| board_id = self._rock_pi_id() | |||
| elif chip_id == chips.RYZEN_V1605B: | |||
| elif self.board_asset_tag == "SC40-2000-0000-C0|C": | |||
There was a problem hiding this comment.
Can we move the actual tag into the constants/board.py file? You could make an IDs tuple like we did for other boards. That way if UDOO adds additional IDs, it's easy to add new ones in and it looks cleaner.
There was a problem hiding this comment.
Like this?`
'_UDOO_BOLT_ASSET = "SC40-2000-0000-C0|C"
_UDOO_IDS = (
UDOO_BOLT,
_UDOO_BOLT_ASSET,
)'
There was a problem hiding this comment.
Not quite. More like:
_UDOO_BOARD_IDS = {
UDOO_BOLT: (
"SC40-2000-0000-C0|C",
)
}
|
One more thing is adding an |
|
No, I mean just the hard-coded number |
|
Hi, I submitted a PR to your repo at geekguy-wy#1 that should make it so that it doesn't break the code for other boards. Please give that a try and then we can get this merged in soon. |
Updated Code for Udoo bolt ID - merging changes
Added board detection for UDOO Bolt using check_board_asset_value() and added it to detect.py