Skip to content

Added board detection for UDOO Bolt using check_board_asset_value() #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 23, 2020
Merged

Added board detection for UDOO Bolt using check_board_asset_value() #81

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
710f368
Added board detection for UDOO Bolt using check_board_asset_value() a…
geekguy-wy May 19, 2020
d0d36d1
Fixed code formatting
geekguy-wy May 19, 2020
a5eb09d
Fixed code formatting, try #2
geekguy-wy May 19, 2020
0de104c
Fixed code formatting, try #3. Oh, my!
geekguy-wy May 19, 2020
d3cc2a2
Fixed code formatting by running black on detect.py, try #4. Oh, my!
geekguy-wy May 19, 2020
ab2bd7d
Changed names of UDOO_IDS and UDOO_ASSET_TAG; Corrected layout of UDO…
geekguy-wy May 20, 2020
4c3b219
Fixed error - added ':' in if statement.'
geekguy-wy May 20, 2020
3fedb68
Merge branch 'add_udoo_bolt_detect' of https://github.com/geekguy-wy/…
makermelissa May 21, 2020
125f2ad
Updated code to search board IDs
makermelissa May 21, 2020
f418f0f
Black formatting, fixed syntax error
makermelissa May 21, 2020
61c0859
Merge branch 'master' of https://github.com/adafruit/Adafruit_Python_…
makermelissa May 21, 2020
e16fed5
Merge pull request #1 from makermelissa/udoo_bolt
geekguy-wy May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion adafruit_platformdetect/board.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ class Board:

def __init__(self, detector):
self.detector = detector
self.board_asset_tag = self.detector.check_board_asset_tag_value().strip()

# pylint: disable=invalid-name, protected-access
@property
Expand Down Expand Up @@ -117,7 +118,7 @@ def id(self):
board_id = self._clockwork_pi_id()
elif chip_id == chips.RK3308:
board_id = self._rock_pi_id()
elif chip_id == chips.RYZEN_V1605B:
elif self.board_asset_tag == "SC40-2000-0000-C0|C":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the actual tag into the constants/board.py file? You could make an IDs tuple like we did for other boards. That way if UDOO adds additional IDs, it's easy to add new ones in and it looks cleaner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this?`
'_UDOO_BOLT_ASSET = "SC40-2000-0000-C0|C"

_UDOO_IDS = (
UDOO_BOLT,
_UDOO_BOLT_ASSET,
)'

Copy link
Collaborator

@makermelissa makermelissa May 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite. More like:

_UDOO_BOARD_IDS = {
    UDOO_BOLT: (
        "SC40-2000-0000-C0|C",
    )
}

board_id = boards.UDOO_BOLT

return board_id
Expand Down
3 changes: 2 additions & 1 deletion bin/detect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
detector = adafruit_platformdetect.Detector()

print("Chip id: ", detector.chip.id)

print("Board id: ", detector.board.id)
print()

print("Is this a DragonBoard 410c?", detector.board.DRAGONBOARD_410C)
print("Is this a Pi 3B+?", detector.board.RASPBERRY_PI_3B_PLUS)
Expand All @@ -23,6 +23,7 @@
print("Is this a Clockwork Pi board?", detector.board.any_clockwork_pi_board)
print("Is this an embedded Linux system?", detector.board.any_embedded_linux)
print("Is this a generic Linux PC?", detector.board.GENERIC_LINUX_PC)
print("Is this a UDOO Bolt?", detector.board.UDOO_BOLT)
print(
"Is this an OS environment variable special case?",
detector.board.FTDI_FT232H
Expand Down