-
-
Notifications
You must be signed in to change notification settings - Fork 251
Upgrade to new securty-group standards #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/test all |
README.yaml
Outdated
If this is not desired behavior, set `transit_encryption_enabled=false`. | ||
|
||
This module creates, by default, a new security group for the Elasticache Redis Cluster. When necessary, it will | ||
replace that security group with a new one. In order to allow terraform to fully manage the security group, you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When necessary, it will replace that security group with a new one
Not clear which one is "that" and which one is new (b/c the previous sentence says "This module creates, by default, a new security group").
Can you elaborate on this sentence?
variables-deprecated.tf
Outdated
EOT | ||
} | ||
locals { | ||
use_legacy_egress = var.egress_cidr_blocks != null && var.egress_cidr_blocks != ["0.0.0.0/0"] && var.allow_all_egress != true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use_legacy_egress = var.egress_cidr_blocks != null && var.egress_cidr_blocks != ["0.0.0.0/0"] && var.allow_all_egress != true | |
use_legacy_egress = var.egress_cidr_blocks != null && !(length(var.egress_cidr_blocks) == 1 && var.egress_cidr_blocks[0] == "0.0.0.0/0") && var.allow_all_egress == false |
Terraform does not support comparing lists using ==
and !=
operators, and can appear to work but will produce unexpected results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few comments
/test all |
what
create_before_destroy
on security groups by defaultwhy
references
Works around Terraform bug with using
coalesce()
orcompact()
in resource inputs.