Feat: Add Broker Node Security Groups #41
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
korenyoni
force-pushed
the
broker_security_groups
branch
from
7c36501 to
6e464ee
Compare
|
/test all |
korenyoni
changed the title
|
/test all |
korenyoni
force-pushed
the
broker_security_groups
branch
from
aa90eb9 to
fce6147
Compare
|
/test all |
|
@korenyoni look at cloudposse/terraform-aws-vpc#100 on new standardized sg 4 inputs and how to deprecate vars cc: @Nuru |
@nitrocode cloudposse/terraform-aws-elasticache-redis#133 is a better example for this type of module (deployed to a VPC) |
|
Closing in favor of #44 |
|
This is superseded by #44 as the standardized SG variable |
korenyoni
changed the title
korenyoni
changed the title
korenyoni
reviewed
Oct 26, 2021
Comment on lines
+16
to
+89
| # var.client_broker types | ||
| plaintext = "PLAINTEXT" | ||
| tls_plaintext = "TLS_PLAINTEXT" | ||
| tls = "TLS" | ||
|
|
||
| # The following ports are not configurable. See: https://docs.aws.amazon.com/msk/latest/developerguide/client-access.html#port-info | ||
| protocols = { | ||
| plaintext = { | ||
| name = "plaintext" | ||
| # https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/msk_cluster#bootstrap_brokers | ||
| enabled = contains([local.plaintext, local.tls_plaintext], var.client_broker) | ||
| port = 9092 | ||
| } | ||
| tls = { | ||
| name = "TLS" | ||
| # https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/msk_cluster#bootstrap_brokers_tls | ||
| enabled = contains([local.tls_plaintext, local.tls], var.client_broker) | ||
| port = 9094 | ||
| } | ||
| sasl_scram = { | ||
| name = "SASL/SCRAM" | ||
| # https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/msk_cluster#bootstrap_brokers_sasl_scram | ||
| enabled = var.client_sasl_scram_enabled && contains([local.tls_plaintext, local.tls], var.client_broker) | ||
| port = 9096 | ||
| } | ||
| sasl_iam = { | ||
| name = "SASL/IAM" | ||
| # https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/msk_cluster#bootstrap_brokers_sasl_iam | ||
| enabled = var.client_sasl_iam_enabled && contains([local.tls_plaintext, local.tls], var.client_broker) | ||
| port = 9098 | ||
| } | ||
| # The following two protocols are always enabled. | ||
| # See: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/msk_cluster#zookeeper_connect_string | ||
| # and https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/msk_cluster#zookeeper_connect_string_tls | ||
| zookeeper_plaintext = { | ||
| name = "Zookeeper plaintext" | ||
| enabled = true | ||
| port = 2181 | ||
| } | ||
| zookeeper_tls = { | ||
| name = "Zookeeper TLS" | ||
| enabled = true | ||
| port = 2182 | ||
| } | ||
| } | ||
| } | ||
|
|
||
| resource "aws_security_group_rule" "ingress_cidr_blocks" { | ||
| count = local.enabled && length(var.allowed_cidr_blocks) > 0 ? 1 : 0 | ||
| description = "Allow inbound traffic from CIDR blocks" | ||
| type = "ingress" | ||
| from_port = 0 | ||
| to_port = 65535 | ||
| protocol = "tcp" | ||
| cidr_blocks = var.allowed_cidr_blocks | ||
| security_group_id = join("", aws_security_group.default.*.id) | ||
| } | ||
| module "broker_security_group" { | ||
| source = "cloudposse/security-group/aws" | ||
| version = "0.4.2" | ||
|
|
||
| attributes = ["broker"] | ||
|
|
||
| security_group_description = "Allow inbound MSK-related traffic from Security Groups and CIDRs. Allow all outbound traffic" | ||
| allow_all_egress = true | ||
| rule_matrix = [ | ||
| { | ||
| source_security_group_ids = var.security_groups | ||
| cidr_blocks = var.allowed_cidr_blocks | ||
| rules = [ | ||
| for protocol_key, protocol in local.protocols : { | ||
| key = protocol_key | ||
| type = "ingress" | ||
| from_port = protocol.port | ||
| to_port = protocol.port | ||
| protocol = "tcp" | ||
| description = "Allow inbound ${protocol.name} traffic" | ||
| } if protocol.enabled | ||
| ] | ||
| } | ||
| ] | ||
| vpc_id = var.vpc_id | ||
|
|
||
| resource "aws_security_group_rule" "egress" { | ||
| count = local.enabled ? 1 : 0 | ||
| description = "Allow all egress traffic" | ||
| type = "egress" | ||
| from_port = 0 | ||
| to_port = 65535 | ||
| protocol = "tcp" | ||
| cidr_blocks = ["0.0.0.0/0"] | ||
| security_group_id = join("", aws_security_group.default.*.id) | ||
| context = module.this.context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references
security_groupsis not being utilized #5