[lerna] upgrade to recent version #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the "yarn upgrade" that came along the lerna upgrade, it was found that the "tslint" dependencies were no longer valid (deprecated, old). Manually running tslint from the master branch revealed that the repo's code has not been following the configured rules, probably for a long time (>100 violations). In consequence, I think the best approach at this time is to remove tslint's dependencies and configs. We can consider adding ESLint to the repo, separately, if desired. Fixes #84 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
force-pushed
the
lerna-upgrade
branch
from
5fe0b4b to
d646072
Compare
bhufmann
approved these changes
Sep 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the "yarn upgrade" that came along the lerna upgrade, it was found that the "tslint" dependencies were no longer valid (deprecated, old).
Manually running tslint from the master branch revealed that the repo's code has not been following the configured rules, probably for a long time (>100 violations). In consequence, I think the best approach at this time is to remove tslint's dependencies and configs.
We can consider adding ESLint to the repo, separately, if desired.
How to test?
Build the repo and run the tests. I have followed the examples given in the repo's README and found them to work. However I got better code coverage test stats when running without the suggested
collectCoverageFromoption. i.e.Running:
yarn test --coverageInstead of:
yarn test --coverage --collectCoverageFrom='src/**/*.ts'In bonus, with the updated dependencies of this PR, we get more colourful results.
yarn audit
Before (master):
This PR:
