Skip to content

[Remote Config] add useEmulator to Remote Config SDK #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Remote Config] add useEmulator to Remote Config SDK #3806

wants to merge 7 commits into from

Conversation

kroikie
Copy link
Contributor

@kroikie kroikie commented Jun 13, 2022

Add useEmulator method to allow Remote Config Emulator usage.

The useEmulator method changes the fetchUrl to point to the emulator. This is inline with useEmulator implementations in other SDKs.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from ? (310ce36) to 88.65% (8566718) by ?.

    23 individual files with coverage change

    FilenameBase (310ce36)Merge (8566718)Diff
    Code.java?0.00%?
    ConfigCacheClient.java?93.33%?
    ConfigContainer.java?92.19%?
    ConfigFetchHandler.java?96.00%?
    ConfigFetchHttpClient.java?86.90%?
    ConfigGetParameterHandler.java?96.45%?
    ConfigMetadataClient.java?90.11%?
    ConfigStorageClient.java?100.00%?
    DefaultsXmlParser.java?0.00%?
    FirebaseRemoteConfig.java?87.61%?
    FirebaseRemoteConfigClientException.java?100.00%?
    FirebaseRemoteConfigException.java?100.00%?
    FirebaseRemoteConfigFetchThrottledException.java?100.00%?
    FirebaseRemoteConfigInfo.java?0.00%?
    FirebaseRemoteConfigInfoImpl.java?100.00%?
    FirebaseRemoteConfigServerException.java?100.00%?
    FirebaseRemoteConfigSettings.java?61.54%?
    FirebaseRemoteConfigValue.java?0.00%?
    FirebaseRemoteConfigValueImpl.java?84.62%?
    Personalization.java?91.43%?
    RemoteConfigComponent.java?96.61%?
    RemoteConfigConstants.java?0.00%?
    RemoteConfigRegistrar.java?100.00%?

Test Logs

Notes

  • Commit (8566718) is created by Prow via merging PR base commit (310ce36) and head commit (07dfb09).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vXHJoyoCQW.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-config:
error: Added method com.google.firebase.remoteconfig.FirebaseRemoteConfig.useEmulator(String,int) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 13, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-config

    TypeBase (310ce36)Merge (8566718)Diff
    aar63.3 kB63.8 kB+480 B (+0.8%)
    apk (release)743 kB743 kB+376 B (+0.1%)

Test Logs

Notes

  • Commit (8566718) is created by Prow via merging PR base commit (310ce36) and head commit (07dfb09).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ssOJYt75xI.html

yuchenshi
yuchenshi approved these changes Jun 13, 2022
View reviewed changes
...se-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigFetchHttpClient.java Outdated
if (emulatedServiceSettings != null) {
fetchRegexUrl =
"http://"
+ emulatedServiceSettings.getHost()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this handle IPv6 addresses correctly, like bracket-quoting ([::1])?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: android docs.

@kroikie kroikie changed the title [WIP] [Remote Config] add useEmulator to Remote Config SDK [Remote Config] add useEmulator to Remote Config SDK Jul 18, 2022
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-config:
error: Added method com.google.firebase.remoteconfig.FirebaseRemoteConfig.useEmulator(String,int) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@kroikie kroikie force-pushed the kroikie-rc-emulator branch from eb5dee1 to 1e8e87f Compare July 18, 2022 15:52
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-config:
error: Added method com.google.firebase.remoteconfig.FirebaseRemoteConfig.useEmulator(String,int) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-config:
error: Added method com.google.firebase.remoteconfig.FirebaseRemoteConfig.useEmulator(String,int) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@jeremyjiang-dev
Copy link
Contributor

/test check-changed

@jhuleatt jhuleatt mentioned this pull request Jul 28, 2022
Draft
@kroikie kroikie force-pushed the kroikie-rc-emulator branch from dcca639 to 0ac6cb0 Compare November 30, 2022 00:03
@kroikie kroikie force-pushed the kroikie-rc-emulator branch from 0ac6cb0 to 1408b76 Compare December 21, 2022 04:35
@kroikie kroikie force-pushed the kroikie-rc-emulator branch from 1408b76 to b5ce88c Compare March 23, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danasilver danasilver danasilver left review comments

@yuchenshi yuchenshi yuchenshi approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kroikie @google-oss-bot @jeremyjiang-dev @danasilver @yuchenshi