Skip to content

[Remote Config] add connectRemoteConfigEmulator to Remote Config #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[Remote Config] add connectRemoteConfigEmulator to Remote Config #6486

wants to merge 7 commits into from

Conversation

jhuleatt
Copy link
Contributor

Add the connectRemoteConfigEmulator function to allow Remote Config Emulator usage. It changes FIREBASE_REMOTE_CONFIG_URL_BASE to point to the emulator. This is similar to the useEmulator implementations in other SDKs (firebase/firebase-android-sdk#3806).

Testing with these (not-yet-merged) CLI branches:

CLI: https://github.com/Firebase/firebase-tools/tree/kroikie-rc-emulator
Emulator UI: https://github.com/Firebase/firebase-tools-ui/tree/jhuleatt-rc-emulator

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 40e184b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/remote-config Minor
firebase Patch
@firebase/remote-config-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 28, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/remote-config

    TypeBase (fa0a7c0)Merge (8d4146a)Diff
    browser19.2 kB19.6 kB+407 B (+2.1%)
    esm524.1 kB24.5 kB+407 B (+1.7%)
    main25.3 kB25.9 kB+545 B (+2.2%)
    module19.2 kB19.6 kB+407 B (+2.1%)

  • @firebase/remote-config-compat

    TypeBase (fa0a7c0)Merge (8d4146a)Diff
    browser1.85 kB1.95 kB+93 B (+5.0%)
    esm52.76 kB2.90 kB+136 B (+4.9%)
    main3.09 kB3.21 kB+121 B (+3.9%)
    module1.85 kB1.95 kB+93 B (+5.0%)

  • bundle

    TypeBase (fa0a7c0)Merge (8d4146a)Diff
    remote-config (getAndFetch)45.4 kB45.4 kB+78 B (+0.2%)

  • firebase

    TypeBase (fa0a7c0)Merge (8d4146a)Diff
    firebase-compat.js747 kB747 kB+324 B (+0.0%)
    firebase-remote-config-compat.js27.2 kB27.5 kB+323 B (+1.2%)
    firebase-remote-config.js26.3 kB26.6 kB+325 B (+1.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PFBo7qQjDH.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 28, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/remote-config

    • activate

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size10.8 kB10.9 kB+78 B (+0.7%)
      size-with-ext-deps36.4 kB36.5 kB+78 B (+0.2%)

    • connectRemoteConfigEmulator

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size?10.8 kB? (?)
      size-with-ext-deps?36.4 kB? (?)

      Dependency

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      functions?

      connectRemoteConfigEmulator
ensureInitialized
getUserLanguage
isRetriableError
openDatabase
registerRemoteConfig
setAbortableTimeout
toFirebaseError

      		?
      classes?

      CachingClient
RemoteConfig
RestClient
RetryingClient
Storage
StorageCache

      		?
      variables?

      APP_NAMESPACE_STORE
DB_NAME
DB_VERSION
DEFAULT_CACHE_MAX_AGE_MILLIS
DEFAULT_FETCH_TIMEOUT_MILLIS
ERROR_DESCRIPTION_MAP
ERROR_FACTORY
RC_COMPONENT_NAME
name
version

      		?
      enums??

      External Dependency

      ModuleBase (fa0a7c0)Merge (8d4146a)Diff
      @firebase/app?

      SDK_VERSION
_registerComponent
registerVersion

      		?
      @firebase/component?

      Component

      		?
      @firebase/logger?

      LogLevel
Logger

      		?
      @firebase/util?

      ErrorFactory
FirebaseError
calculateBackoffMillis
getModularInstance
isIndexedDBAvailable

      		?

    • ensureInitialized

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size10.5 kB10.6 kB+78 B (+0.7%)
      size-with-ext-deps36.1 kB36.2 kB+78 B (+0.2%)

    • fetchAndActivate

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size11.4 kB11.5 kB+78 B (+0.7%)
      size-with-ext-deps37.1 kB37.1 kB+78 B (+0.2%)

    • fetchConfig

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size11.1 kB11.2 kB+78 B (+0.7%)
      size-with-ext-deps36.7 kB36.8 kB+78 B (+0.2%)

    • getAll

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size11.7 kB11.8 kB+78 B (+0.7%)
      size-with-ext-deps37.3 kB37.4 kB+78 B (+0.2%)

    • getBoolean

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size11.5 kB11.6 kB+78 B (+0.7%)
      size-with-ext-deps37.2 kB37.2 kB+78 B (+0.2%)

    • getNumber

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size11.5 kB11.6 kB+78 B (+0.7%)
      size-with-ext-deps37.2 kB37.2 kB+78 B (+0.2%)

    • getRemoteConfig

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size10.6 kB10.7 kB+78 B (+0.7%)
      size-with-ext-deps43.3 kB43.4 kB+78 B (+0.2%)

    • getString

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size11.5 kB11.6 kB+78 B (+0.7%)
      size-with-ext-deps37.2 kB37.2 kB+78 B (+0.2%)

    • getValue

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size11.5 kB11.6 kB+78 B (+0.7%)
      size-with-ext-deps37.1 kB37.2 kB+78 B (+0.2%)

    • isSupported

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size10.6 kB10.7 kB+78 B (+0.7%)
      size-with-ext-deps36.2 kB36.3 kB+78 B (+0.2%)

    • setLogLevel

      Size

      TypeBase (fa0a7c0)Merge (8d4146a)Diff
      size10.7 kB10.8 kB+78 B (+0.7%)
      size-with-ext-deps36.3 kB36.4 kB+78 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gckC0itOnu.html

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@jhuleatt jhuleatt force-pushed the jhuleatt-rc-emulator branch from 4ce1104 to fa979f7 Compare February 9, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikeldridge erikeldridge Awaiting requested review from erikeldridge erikeldridge will be requested when the pull request is marked ready for review erikeldridge is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhuleatt @google-oss-bot