-
Notifications
You must be signed in to change notification settings - Fork 23
Project names are displayed in summary when access to Gradle Enterprise API is not available #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e260d14
Fix typo
erichaagdev bb3b160
Include rootProjectName in build-scans.csv for Gradle
erichaagdev 16326f0
Include rootProjectName in build-scans.csv for Maven
erichaagdev e79fbbe
Set project name from build-scans.csv in scripts
erichaagdev 95a8aeb
Polish a bit
etiennestuder 07116d0
Use same override logic for Build Scan IDs as Build Scan URLs
erichaagdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...gure-gradle-enterprise-maven-extension/src/main/java/com/gradle/RootProjectExtractor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
package com.gradle; | ||
|
||
import org.apache.maven.execution.MavenExecutionRequest; | ||
import org.apache.maven.execution.MavenSession; | ||
import org.apache.maven.model.building.ModelProcessor; | ||
import org.apache.maven.project.MavenProject; | ||
import org.apache.maven.project.ProjectBuilder; | ||
import org.apache.maven.project.ProjectBuildingException; | ||
import org.codehaus.plexus.logging.Logger; | ||
|
||
import javax.inject.Inject; | ||
import java.io.File; | ||
import java.util.*; | ||
|
||
import static java.util.Collections.emptyList; | ||
|
||
public class RootProjectExtractor { | ||
|
||
private final ProjectBuilder projectBuilder; | ||
private final ModelProcessor modelProcessor; | ||
private final Logger logger; | ||
|
||
@Inject | ||
public RootProjectExtractor(ProjectBuilder projectBuilder, ModelProcessor modelProcessor, Logger logger) { | ||
this.projectBuilder = projectBuilder; | ||
this.modelProcessor = modelProcessor; | ||
this.logger = logger; | ||
} | ||
|
||
public MavenProject extractRootProject(MavenSession session) { | ||
List<MavenProject> allProjects = discoverAllProjects(session.getAllProjects()); | ||
File workspaceDirectory = getWorkspaceDirectory(session); | ||
|
||
if (workspaceDirectory.equals(allProjects.get(0).getBasedir())) { | ||
return allProjects.get(0); | ||
} | ||
|
||
File workspaceDirectoryPom = modelProcessor.locatePom(workspaceDirectory); | ||
if (workspaceDirectoryPom.exists()) { | ||
try { | ||
return projectBuilder.build(workspaceDirectoryPom, session.getProjectBuildingRequest()).getProject(); | ||
} catch (ProjectBuildingException e) { | ||
logger.error("Error locating the top level project", e); | ||
} | ||
} | ||
|
||
// return the first project if the top level project was not identified successfully | ||
return allProjects.get(0); | ||
} | ||
|
||
private File getWorkspaceDirectory(MavenSession session) { | ||
MavenExecutionRequest request = session.getRequest(); | ||
try { | ||
return request.getMultiModuleProjectDirectory(); | ||
} catch (NoSuchMethodError ignored) { | ||
return new File(session.getExecutionRootDirectory()); | ||
} | ||
} | ||
|
||
private List<MavenProject> discoverAllProjects(Collection<MavenProject> sessionProjects) { | ||
Set<MavenProject> allProjects = new LinkedHashSet<>(sessionProjects); | ||
sessionProjects.stream().flatMap(p -> Optional.ofNullable(p.getCollectedProjects()).orElse(emptyList()).stream()).forEach(allProjects::add); | ||
return new ArrayList<MavenProject>(allProjects); | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.