Project names are displayed in summary when access to Gradle Enterprise API is not available #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaagdev
force-pushed
the
erichaagdev/extract-name-from-project
branch
from
baaa514 to
cf1a6ac
Compare
erichaagdev
commented
Apr 13, 2023
...nfigure-gradle-enterprise-maven-extension/src/main/java/com/gradle/RootProjectExtractor.java
Show resolved
Hide resolved
components/scripts/gradle/gradle-init-scripts/configure-gradle-enterprise.gradle
Outdated
Show resolved
Hide resolved
...nfigure-gradle-enterprise-maven-extension/src/main/java/com/gradle/RootProjectExtractor.java
Outdated
Show resolved
Hide resolved
etiennestuder
approved these changes
Apr 13, 2023
erichaagdev
force-pushed
the
erichaagdev/extract-name-from-project
branch
from
e0bf269 to
07116d0
Compare
erichaagdev
added a commit
that referenced
this pull request
Apr 19, 2023
* origin/main: (39 commits) Bump info.picocli:picocli from 4.7.2 to 4.7.3 Gradle 8.1 considers signing task to be compatible with configuration cache Remove legacy build time field (#409) Use Provider API to read version and changes files Update gradle.properties Prepare for next round of development Update changes.md Prepare for 2.3.5 release Revert GE Maven extension to version 1.16.6 Prepare for next round of development Prepare for 2.3.4 release Revert "Use Provider API to read version and changes files" Project names are displayed in summary when access to Gradle Enterprise API is not available (#400) Use Provider API to read version and changes files Bump com.gradle.enterprise from 3.12.6 to 3.13 Bump com.gradle:gradle-enterprise-maven-extension from 1.16.6 to 1.17 Bump Gradle Wrapper from 8.0.2 to 8.1 Flip if condition for clarity Remove build_cache_metrics_only and all_data Update changes.md ... # Conflicts: # components/scripts/lib/build-scan-offline.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #263 a change was made to always read the project name from the Gradle Enterprise API. All code around extracting the project name locally was removed. Unfortunately, the use case of not having access to the Gradle Enterprise API was not considered and therefore a regression was introduced.
Currently, without these changes, if Gradle Enterprise API access is not configured, the project name will be unknown.
With these changes, the project name will be shown even without Gradle Enterprise API access.
And for Maven (before | after):