Skip to content

Unused build time field is removed from Java command line tool response #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

erichaagdev
Copy link
Member

In #383, the build time field was superseded by the "initial" and "instant" build time fields. This PR removes all references to the build time field as it is no longer used.

@erichaagdev erichaagdev self-assigned this Apr 17, 2023
Copy link
Member

@etiennestuder etiennestuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Same change to be done in the offline mode?

@erichaagdev
Copy link
Member Author

LGTM. Same change to be done in the offline mode?

Yep. It's finished, just testing it. Will have a PR shortly.

@erichaagdev erichaagdev merged commit cb2eaa1 into main Apr 17, 2023
@erichaagdev erichaagdev deleted the erichaagdev/remove-build-time-field branch April 17, 2023 19:40
erichaagdev added a commit that referenced this pull request Apr 19, 2023
* origin/main: (39 commits)
  Bump info.picocli:picocli from 4.7.2 to 4.7.3
  Gradle 8.1 considers signing task to be compatible with configuration cache
  Remove legacy build time field (#409)
  Use Provider API to read version and changes files
  Update gradle.properties
  Prepare for next round of development
  Update changes.md
  Prepare for 2.3.5 release
  Revert GE Maven extension to version 1.16.6
  Prepare for next round of development
  Prepare for 2.3.4 release
  Revert "Use Provider API to read version and changes files"
  Project names are displayed in summary when access to Gradle Enterprise API is not available (#400)
  Use Provider API to read version and changes files
  Bump com.gradle.enterprise from 3.12.6 to 3.13
  Bump com.gradle:gradle-enterprise-maven-extension from 1.16.6 to 1.17
  Bump Gradle Wrapper from 8.0.2 to 8.1
  Flip if condition for clarity
  Remove build_cache_metrics_only and all_data
  Update changes.md
  ...

# Conflicts:
#	components/scripts/lib/build-scan-offline.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants