Always read project name from Build Scan data

[erichaagdev]

❄️ Winter Update PR Navigator ❄️

1. Include realized build time savings in experiment summary #261
2. Include performance characteristics and support -x for Gradle experiment 1  #262
3. ⛄ Always read project name from Build Scan data #263
4. Gradle init script improvements #264
5. Adopt Foojay Toolchains and Kotlin DSL plugins in build logic #265
6. Add variable to query debug mode #266
7. Modernize Java launch code #267
8. Display serialization factor in summary of all experiments #272
9. Display potential build time savings in experiment summaries #274
10. Update the contract of command line tools #283

⛄ = you are here

Summary

ℹ️ This PR continues the implementation of #206. This felt like a good place to stop. More PRs will be coming.

This PR introduces the following changes:

• Removed all reading and writing of project name to the build-scans.csv file
• Removed many redundant occurrences of reading the build-scans.csv file
  • In most cases it was being read twice, or three times when in interactive mode
• Added debug logging for build-scans.csv that was very useful when testing this PR

These changes do not introduce any visual changes in user facing output.

Testing

I ran all of the following experiments and inspected the output. I ensured that:

• All summary information was displayed as expected, including the project name
• The build-scans.csv file was only ever being read once

./01-validate-incremental-building.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' --debug
./01-validate-incremental-building.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -i --debug
./01-validate-incremental-building.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -x --debug
./01-validate-incremental-building.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -i -x --debug
./02-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' --debug
./02-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -i --debug
./02-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -x --debug
./02-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -i -x --debug
./03-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' --debug
./03-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -i --debug
./03-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -x --debug
./03-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -i -x --debug
./04-validate-remote-build-caching-ci-ci.sh -1 https://ge.solutions-team.gradle.com/s/fvwne3ht4xgjg -2 https://ge.solutions-team.gradle.com/s/tjiwbi2b7oioo --debug
./04-validate-remote-build-caching-ci-ci.sh -1 https://ge.solutions-team.gradle.com/s/fvwne3ht4xgjg -2 https://ge.solutions-team.gradle.com/s/tjiwbi2b7oioo -i --debug
./05-validate-remote-build-caching-ci-local.sh -1 https://ge.solutions-team.gradle.com/s/lc73bw56kdkxi --debug
./05-validate-remote-build-caching-ci-local.sh -1 https://ge.solutions-team.gradle.com/s/lc73bw56kdkxi -i --debug
./01-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/maven/3.8.x/ge -g 'package' --debug
./01-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/maven/3.8.x/ge -g 'package' -i --debug
./01-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/maven/3.8.x/ge -g 'package' -x --debug
./01-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/maven/3.8.x/ge -g 'package' -i -x --debug
./02-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/maven/3.8.x/ge -g 'package' --debug
./02-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/maven/3.8.x/ge -g 'package' -i --debug
./02-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/maven/3.8.x/ge -g 'package' -x --debug
./02-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/maven/3.8.x/ge -g 'package' -i -x --debug
./03-validate-remote-build-caching-ci-ci.sh -1 https://ge.solutions-team.gradle.com/s/nhrdhjwc6nysy -2 https://ge.solutions-team.gradle.com/s/v7folxiq3dkyk --debug
./03-validate-remote-build-caching-ci-ci.sh -1 https://ge.solutions-team.gradle.com/s/nhrdhjwc6nysy -2 https://ge.solutions-team.gradle.com/s/v7folxiq3dkyk -i --debug
./04-validate-remote-build-caching-ci-local.sh -1 https://ge.solutions-team.gradle.com/s/ehiqsjd2wh5qs --debug
./04-validate-remote-build-caching-ci-local.sh -1 https://ge.solutions-team.gradle.com/s/ehiqsjd2wh5qs -i --debug

[runningcode]

I don't have the full context to review this but I just added a comment.

[jthurne]

It is great to see this bit of technical debt finally cleaned up!