Skip to content

Include performance characteristics and support -x for Gradle experiment 1 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erichaagdev
Copy link
Member

@erichaagdev erichaagdev commented Dec 28, 2022

❄️ Winter Update PR Navigator ❄️

  1. Include realized build time savings in experiment summary #261
  2. Include performance characteristics and support -x for Gradle experiment 1  #262
  3. Always read project name from Build Scan data #263
  4. Gradle init script improvements #264
  5. Adopt Foojay Toolchains and Kotlin DSL plugins in build logic #265
  6. Add variable to query debug mode #266
  7. Modernize Java launch code #267
  8. Display serialization factor in summary of all experiments #272
  9. Display potential build time savings in experiment summaries #274
  10. Update the contract of command line tools #283

⛄ = you are here

Summary

ℹ️ This PR continues the implementation of #206. This felt like a good place to stop. More PRs will be coming.

This PR introduces the following changes:

  • The summary of Gradle experiment 1 now includes a Performance Characteristics section that includes Effective task execution duration
  • Gradle experiment 1 can now be run with -x / --disable-build-scan-publishing

Testing

Enabled Build Scan publishing

Non-interactive

./01-validate-incremental-building.sh \
  -r git@github.com:gradle/ge-solutions.git \
  -p sample-projects/gradle/7.x/ge \
  -t 'build'

image

Interactive

./01-validate-incremental-building.sh \
  -r git@github.com:gradle/ge-solutions.git \
  -p sample-projects/gradle/7.x/ge \
  -t 'build' \
  -i

image

image

image

Disabled Build Scan publishing

⚠️ The Performance Characteristics section is intentionally empty with -x because the build-scan-support-tool.jar does not return the required Effective task execution duration field. Once this required field is returned, the section will include the new Realized build time savings field as expected.

Non-interactive

./01-validate-incremental-building.sh \
  -r git@github.com:gradle/ge-solutions.git \
  -p sample-projects/gradle/7.x/ge \
  -t 'build' \
  -x

image

Interactive

./01-validate-incremental-building.sh \
  -r git@github.com:gradle/ge-solutions.git \
  -p sample-projects/gradle/7.x/ge \
  -t 'build' \
  -i \
  -x

image

image

image

@runningcode runningcode removed their request for review February 28, 2023 11:39
@erichaagdev erichaagdev force-pushed the erichaagdev/display-realized-build-time-savings branch from bcadbb4 to c1d8a1a Compare March 6, 2023 00:03
@erichaagdev erichaagdev force-pushed the erichaagdev/exp1-display-realized-build-time-savings branch from c518ff2 to 127b270 Compare March 6, 2023 00:06
Base automatically changed from erichaagdev/display-realized-build-time-savings to main March 6, 2023 15:57
@erichaagdev erichaagdev merged commit da175ff into main Mar 6, 2023
@erichaagdev erichaagdev deleted the erichaagdev/exp1-display-realized-build-time-savings branch March 6, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants