Skip to content

Modernize Java launch code #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

erichaagdev
Copy link
Member

@erichaagdev erichaagdev commented Dec 30, 2022

❄️ Winter Update PR Navigator ❄️

  1. Include realized build time savings in experiment summary #261
  2. Include performance characteristics and support -x for Gradle experiment 1  #262
  3. Always read project name from Build Scan data #263
  4. Gradle init script improvements #264
  5. Adopt Foojay Toolchains and Kotlin DSL plugins in build logic #265
  6. Add variable to query debug mode #266
  7. Modernize Java launch code #267
  8. Display serialization factor in summary of all experiments #272
  9. Display potential build time savings in experiment summaries #274
  10. Update the contract of command line tools #283

⛄ = you are here

Summary

This PR updates the Java launch code used to invoke the command line tools.

Closes #176

Testing

In order to test this, I ran Gradle experiments 1-3 both online and offline:

./01-validate-incremental-building.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build'
./01-validate-incremental-building.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -x
./02-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build'
./02-validate-local-build-caching-same-location.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -x
./03-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build'
./03-validate-local-build-caching-different-locations.sh -r git@github.com:gradle/ge-solutions.git -p sample-projects/gradle/7.x/ge -t 'build' -x

Copy link
Member

@jthurne jthurne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The optional comments I left might be worth considering if we're okay with deviating from the application plugin's template script. If we want this to closely match the template script, then its fine to leave them unaddressed.

@erichaagdev
Copy link
Member Author

The optional comments I left might be worth considering if we're okay with deviating from the application plugin's template script. If we want this to closely match the template script, then its fine to leave them unaddressed.

These are great suggestions! I intentionally left the code as close to its source (the template script) as I could. I'm fine implementing these changes but I'm unsure of the impact, if any. @etiennestuder wdyt?

@runningcode runningcode removed their request for review March 1, 2023 09:08
@erichaagdev erichaagdev force-pushed the erichaagdev/debug_mode_variable branch from 18840cc to 631b31c Compare March 6, 2023 00:35
@erichaagdev erichaagdev force-pushed the erichaagdev/modernize-java-launch-code branch from 7dc138b to c65b367 Compare March 6, 2023 00:39
Base automatically changed from erichaagdev/debug_mode_variable to main March 7, 2023 20:31
@erichaagdev erichaagdev merged commit 016d938 into main Mar 7, 2023
@erichaagdev erichaagdev deleted the erichaagdev/modernize-java-launch-code branch March 7, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java launch code is modernized
3 participants