-
Notifications
You must be signed in to change notification settings - Fork 23
Display potential build time savings in experiment summaries #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erichaagdev
merged 3 commits into
main
from
erichaagdev/display-potential-build-time-savings
Mar 7, 2023
Merged
Display potential build time savings in experiment summaries #274
erichaagdev
merged 3 commits into
main
from
erichaagdev/display-potential-build-time-savings
Mar 7, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2023
erichaagdev
commented
Jan 4, 2023
erichaagdev
commented
Jan 4, 2023
erichaagdev
commented
Jan 4, 2023
...nents/fetch-build-scan-data-cmdline-tool/src/main/java/com/gradle/enterprise/cli/Fields.java
Show resolved
Hide resolved
This was referenced Jan 6, 2023
jthurne
reviewed
Jan 7, 2023
jthurne
approved these changes
Jan 7, 2023
0404f37
to
e31a63d
Compare
dec7d87
to
9e73951
Compare
jthurne
reviewed
Mar 6, 2023
Base automatically changed from
erichaagdev/display-serialization-factor
to
main
March 7, 2023 21:17
etiennestuder
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Winter Update PR Navigator ❄️
-x
for Gradle experiment 1 #262⛄ = you are here
Summary
ℹ️ This PR continues the implementation of #206. This felt like a good place to stop. More PRs will be coming.
This PR adds the
potential_build_time
andpotential_build_time_savings
, which is calculated as:This is then displayed to the user as in the following example:
Testing
These changes were tested by running the following experiments and verifying they display a potential build time and potential build time savings. Note the exclusion of
exp5-gradle
andexp4-maven
. I excluded these because I could not easily find a CI build with a cache miss.