Skip to content

Adopt Foojay Toolchains and Kotlin DSL plugins in build logic #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 7, 2023
Merged

Adopt Foojay Toolchains and Kotlin DSL plugins in build logic #265

merged 7 commits into from
Mar 7, 2023

Conversation

erichaagdev
Copy link
Member

@erichaagdev erichaagdev commented Dec 30, 2022 •
edited
Loading

❄️ Winter Update PR Navigator ❄️

  1. Include realized build time savings in experiment summary #261
  2. Include performance characteristics and support -x for Gradle experiment 1  #262
  3. Always read project name from Build Scan data #263
  4. Gradle init script improvements #264
  5. ⛄ Adopt Foojay Toolchains and Kotlin DSL plugins in build logic #265
  6. Add variable to query debug mode #266
  7. Modernize Java launch code #267
  8. Display serialization factor in summary of all experiments #272
  9. Display potential build time savings in experiment summaries #274
  10. Update the contract of command line tools #283

⛄ = you are here

Summary

This PR updates buildSrc to auto-provision the required JVM toolchains using the Foojay Toolchains Plugin and sets the distribution vendor to AZUL.

Additionally, I updated buildSrc to use the kotlin-dsl plugin. See this comment for context

Closes #254

@erichaagdev erichaagdev self-assigned this Dec 30, 2022
@erichaagdev erichaagdev changed the title Build logic improvements Adopt Foojay Toolchains and Kotlin DSL plugins in build logic Dec 30, 2022
@erichaagdev erichaagdev mentioned this pull request Dec 30, 2022
Closed
@erichaagdev erichaagdev marked this pull request as ready for review December 30, 2022 17:47
This was referenced Dec 30, 2022
Merged
Merged
Merged
Merged
Merged
Merged
runningcode
runningcode approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please wait for others to review as well.

This was referenced Jan 3, 2023
Merged
Merged
Merged
jthurne
jthurne approved these changes Jan 7, 2023
View reviewed changes
@erichaagdev erichaagdev force-pushed the erichaagdev/init-script-cleanup branch from ae59a4b to 7e0594d Compare March 6, 2023 00:16
@erichaagdev erichaagdev force-pushed the erichaagdev/buildSrc-improvements branch from 62d3c2e to 808b3d0 Compare March 6, 2023 00:29
Base automatically changed from erichaagdev/init-script-cleanup to main March 7, 2023 18:07
@erichaagdev
Set toolchain vendor to Azul
a0ab8d9 
Azul has been chosen due to its wide range of supported platforms for Java 8,
including arm64 for macOS.

See: https://foojay.io/almanac/jdk-8
@erichaagdev erichaagdev merged commit 1670995 into main Mar 7, 2023
@erichaagdev erichaagdev deleted the erichaagdev/buildSrc-improvements branch March 7, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennestuder etiennestuder etiennestuder approved these changes

@runningcode runningcode runningcode approved these changes

@jthurne jthurne jthurne approved these changes

Assignees

@erichaagdev erichaagdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt Foojay Toolchains plugin to resolve required toolchains for development
4 participants
@erichaagdev @etiennestuder @runningcode @jthurne