-
Notifications
You must be signed in to change notification settings - Fork 23
Update the contract of command line tools #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
They are not breaking changes from an end-user perspective. These are just breaking changes to our internal contract between the build validation scripts and the utilities which read the Build Scan data. I make this comment because this change does not necessitate bumping the major version of the build validation scripts. |
I just remembered that we distribute build-scan-support-tools separately from the scripts. So while this is an update to an internal private API, it does mean that newer versions of the build validation scripts will be incompatible with earlier versions of the build-scan-support-tools. This is fine if we haven't given the build-scan-support-tools to anyone yet. But if we have, we may want to start keeping a compatibility matrix to show which versions of the build-scan-support-tools are compatible with which versions of the build validation scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cleans things up nicely. It would be good to update build-scan-support-tools soon so that we can merge this with the other PRs.
I don't believe we've distributed it yet. I do have similar concerns on how to best handle the versioning between all tools (Gradle Enterprise version, Gradle version, CLI tools, and the scripts themselves). |
dec7d87
to
9e73951
Compare
c501db7
to
4b901ec
Compare
...ta-cmdline-tool/src/main/java/com/gradle/enterprise/cli/FetchBuildValidationDataCommand.java
Show resolved
Hide resolved
...ta-cmdline-tool/src/main/java/com/gradle/enterprise/cli/FetchBuildValidationDataCommand.java
Show resolved
Hide resolved
4b901ec
to
7ff7ed0
Compare
❄️ Winter Update PR Navigator ❄️
-x
for Gradle experiment 1 #262⛄ = you are here
Summary
This PR cleans up and simplifies the contract of the Build Scan CSV sent by the command line tools. This is the final PR for implementing #206.
ℹ️ This PR is related to gradle/ge#19681 which contains the corresponding changes to support offline processing.
Examples:
Testing
To test this, I ran all of the following experiments and examined their output was as expected. For those experiments using
-x
, I used the latest version of thebuild-scan-support-tool
based on the changes in gradle/ge#19681.