Skip to content

Port widening SymbolConstructor unique symbol properties #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
621 changes: 321 additions & 300 deletions internal/checker/checker.go

Large diffs are not rendered by default.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ interface SymbolConstructor {
readonly observer: unique symbol;
}
declare const obj: {
[x: symbol]: number;
[Symbol.observer]: number;
};

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,22 @@
=== symbolObserverMismatchingPolyfillsWorkTogether.ts ===
interface SymbolConstructor {
readonly observer: symbol;
>observer : symbol
>observer : unique symbol
}
interface SymbolConstructor {
readonly observer: unique symbol;
>observer : symbol
>observer : unique symbol
}

const obj = {
>obj : { [x: symbol]: number; }
>{ [Symbol.observer]: 0} : { [x: symbol]: number; }
>obj : { [Symbol.observer]: number; }
>{ [Symbol.observer]: 0} : { [Symbol.observer]: number; }

[Symbol.observer]: 0
>[Symbol.observer] : number
>Symbol.observer : symbol
>Symbol.observer : unique symbol
>Symbol : SymbolConstructor
>observer : symbol
>observer : unique symbol
>0 : 0

};

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,11 @@ declare global {
readonly obs: symbol;
}
}
declare const observable: typeof Symbol.obs;
export declare class MyObservable<T> {
[x: symbol]: () => this;
private _val;
constructor(_val: T);
subscribe(next: (val: T) => void): void;
[observable](): this;
}
export {};
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,4 @@
+ _val;
constructor(_val) {
this._val = _val;
}
@@= skipped -22, +23 lines =@@
readonly obs: symbol;
}
}
-declare const observable: typeof Symbol.obs;
export declare class MyObservable<T> {
+ [x: symbol]: () => this;
private _val;
constructor(_val: T);
subscribe(next: (val: T) => void): void;
- [observable](): this;
}
-export {};
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@ declare global {

interface SymbolConstructor {
readonly obs: symbol
>obs : symbol
>obs : unique symbol
}
}

const observable: typeof Symbol.obs = Symbol.obs
>observable : symbol
>Symbol.obs : symbol
>observable : unique symbol
>Symbol.obs : unique symbol
>Symbol : SymbolConstructor
>obs : symbol
>Symbol.obs : symbol
>obs : unique symbol
>Symbol.obs : unique symbol
>Symbol : SymbolConstructor
>obs : symbol
>obs : unique symbol

export class MyObservable<T> {
>MyObservable : MyObservable<T>
Expand All @@ -40,7 +40,7 @@ export class MyObservable<T> {

[observable]() {
>[observable] : () => this
>observable : symbol
>observable : unique symbol

return this
>this : this
Expand All @@ -52,9 +52,9 @@ type InteropObservable<T> = {

[Symbol.obs]: () => { subscribe(next: (val: T) => void): void }
>[Symbol.obs] : () => { subscribe(next: (val: T) => void): void; }
>Symbol.obs : symbol
>Symbol.obs : unique symbol
>Symbol : SymbolConstructor
>obs : symbol
>obs : unique symbol
>subscribe : (next: (val: T) => void) => void
>next : (val: T) => void
>val : T
Expand All @@ -68,9 +68,9 @@ function from<T>(obs: InteropObservable<T>) {
>obs[Symbol.obs]() : { subscribe(next: (val: T) => void): void; }
>obs[Symbol.obs] : () => { subscribe(next: (val: T) => void): void; }
>obs : InteropObservable<T>
>Symbol.obs : symbol
>Symbol.obs : unique symbol
>Symbol : SymbolConstructor
>obs : symbol
>obs : unique symbol
}

from(new MyObservable(42))
Expand Down

This file was deleted.