Port widening SymbolConstructor unique symbol properties
#1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeAbby
changed the title
SymbolConstructor unique symbol properties
LukeAbby
commented
Jun 19, 2025
LukeAbby
force-pushed
the
widenSymbolConstructor
branch
2 times, most recently
from
2773292 to
02b8cb6
Compare
jakebailey
reviewed
Jun 19, 2025
testdata/baselines/reference/submodule/conformance/symbolProperty61.js.diff
Outdated
Show resolved
Hide resolved
LukeAbby
force-pushed
the
widenSymbolConstructor
branch
from
02b8cb6 to
18311b7
Compare
jakebailey
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1212
Fixes #1220
Note the large diff is because
getGlobalESSymbolConstructorTypeSymbolOrNilis now the largest name in theCheckerstruct.