fix: properly index otherwise ignored dependency #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #272. The core framework dependency needs to be a runtime dependency so that it gets put in the extension-using application. We also need to index the dependency explicitly because Quarkus doesn't do it automatically (as things might get unruly fast).
|
Can we have a test, either unit test or integration test for this fix? to ensure the same issue wouldn't happen again later on. |
Yes, definitely. |
Thanks |
metacosm
force-pushed
the
index-core-dependency
branch
from
113799b to
6e97452
Compare
metacosm
force-pushed
the
index-core-dependency
branch
from
7ff7e8d to
7664b85
Compare
This is needed because we cannot currently use QuarkusUnitTest because of an issue with the kubernetes extension and it's not possible to inject beans in a test using QuarkusProdModeTest. The workaround then is to create a separate app that's started using QuarkusProdModeTest and that exposes some information that we can check over REST about the injected beans to verify that they are indeed properly injected.
metacosm
force-pushed
the
index-core-dependency
branch
from
7664b85 to
ba20028
Compare
|
Ready for merge. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272. The core framework dependency needs to be a runtime
dependency so that it gets put in the extension-using application. We
also need to index the dependency explicitly because Quarkus doesn't do
it automatically (as things might get unruly fast).