Change for Docker PostgreSQL to Version 17 and OpenProject to Version 16 #19011
Conversation
| @@ -15,8 +15,8 @@ ENV DOCKER=1 | |||
| ENV APP_USER=app | |||
| ENV APP_PATH=/app | |||
| ENV APP_DATA_PATH=/var/openproject/assets | |||
| ENV PGVERSION="13" | |||
| ENV PGVERSION_CHOICES="13 15 17" | |||
| ENV PGVERSION="17" | |||
There was a problem hiding this comment.
This is not correct, as changing this line will not auto-migrate for existing installations. If you install OpenProject from a new installation, it's preferable to set PGVERSION=17 explicitly
| @@ -15,7 +15,7 @@ services: | |||
| web: &openproject | |||
| environment: | |||
| - DATABASE_URL=postgres://postgres:p4ssw0rd@database/openproject | |||
| image: openproject/openproject:15 | |||
| image: openproject/openproject:16 | |||
There was a problem hiding this comment.
This file isn't linked anywhere as far as I can tell, I removed it on dev
| @@ -45,7 +45,7 @@ services: | |||
| - "caddy_data:/data" | |||
|
|
|||
| db: | |||
| image: postgres:13 | |||
| image: postgres:17 | |||
| @@ -3,7 +3,7 @@ set -e | |||
| set -o pipefail | |||
|
|
|||
| CURRENT_PGVERSION="$(cat $PGDATA/PG_VERSION)" | |||
| NEW_PGVERSION="13" | |||
| NEW_PGVERSION="17" | |||
There was a problem hiding this comment.
Already changed in #19010
| @@ -1,6 +1,6 @@ | |||
| services: | |||
| db-keycloak: | |||
| image: postgres:13 | |||
| image: postgres:17 | |||
There was a problem hiding this comment.
Not sure if we want to raise this /cc @NobodysNightmare
There was a problem hiding this comment.
Since this docker-compose file is for development setups only, it should not be able to fix any user-facing issues.
That said, it's probably a good idea to raise it anyways. Keycloak is officially tested against PG 17 and at some point using an outdated database would bite us.
So for me it's okay to raise it.
| @@ -6,7 +6,7 @@ ENV NODE_VERSION="22.15.0" | |||
| ENV DEBIAN_FRONTEND=noninteractive | |||
| ENV BUNDLE_WITHOUT="development:production:docker" | |||
|
|
|||
| ENV PGVERSION=13 | |||
| ENV PGVERSION=17 | |||
There was a problem hiding this comment.
We want to keep the CI running on PSQL 13, as we only soft-deprecated the version, and will raise this only when a true deprecation is released.
There was a problem hiding this comment.
"The PostgreSQL Global Development Group supports a major version for 5 years after its initial release. After this, a final minor version will be released and the software will then be unsupported (end-of-life).
(For version 13) This will be on November 13, 2025." https://www.postgresql.org/support/versioning/
Ticket
Solves this:
Not sure if this line for handling legacy configs could use some change too.
What are you trying to accomplish?
Merge checklist