-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Change for Docker PostgreSQL to Version 17 and OpenProject to Version 16 #19011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# DB Version: 13 | ||
# DB Version: 17 | ||
# OS Type: linux | ||
# DB Type: web | ||
# Total Memory (RAM): 32 GB | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
services: | ||
db-keycloak: | ||
image: postgres:13 | ||
image: postgres:17 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if we want to raise this /cc @NobodysNightmare There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this docker-compose file is for development setups only, it should not be able to fix any user-facing issues. That said, it's probably a good idea to raise it anyways. Keycloak is officially tested against PG 17 and at some point using an outdated database would bite us. So for me it's okay to raise it. |
||
restart: unless-stopped | ||
networks: | ||
- external | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,8 +15,8 @@ ENV DOCKER=1 | |
ENV APP_USER=app | ||
ENV APP_PATH=/app | ||
ENV APP_DATA_PATH=/var/openproject/assets | ||
ENV PGVERSION="13" | ||
ENV PGVERSION_CHOICES="13 15 17" | ||
ENV PGVERSION="17" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not correct, as changing this line will not auto-migrate for existing installations. If you install OpenProject from a new installation, it's preferable to set PGVERSION=17 explicitly |
||
ENV PGVERSION_CHOICES="17" | ||
ENV PGBIN="/usr/lib/postgresql/$PGVERSION/bin" | ||
ENV PATH="$PGBIN:$PATH" | ||
ENV BUNDLE_WITHOUT="development:test" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ set -e | |
set -o pipefail | ||
|
||
CURRENT_PGVERSION="$(cat $PGDATA/PG_VERSION)" | ||
NEW_PGVERSION="13" | ||
NEW_PGVERSION="17" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Already changed in #19010 |
||
|
||
if [ "$CURRENT_PGVERSION" == "$NEW_PGVERSION" ]; then | ||
echo "Current and new postgres version are identical. Aborting." | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ services: | |
- "caddy_data:/data" | ||
|
||
db: | ||
image: postgres:13 | ||
image: postgres:17 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is fine to keep |
||
environment: | ||
POSTGRES_USER: app | ||
POSTGRES_PASSWORD: p4ssw0rd | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
version: '3' | ||
services: | ||
database: | ||
image: postgres:10 | ||
image: postgres:17 | ||
environment: | ||
- POSTGRES_PASSWORD=p4ssw0rd | ||
- POSTGRES_DB=openproject | ||
|
@@ -15,7 +15,7 @@ services: | |
web: &openproject | ||
environment: | ||
- DATABASE_URL=postgres://postgres:p4ssw0rd@database/openproject | ||
image: openproject/openproject:15 | ||
image: openproject/openproject:16 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file isn't linked anywhere as far as I can tell, I removed it on dev |
||
command: ./docker/web | ||
worker: | ||
<<: *openproject | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to keep the CI running on PSQL 13, as we only soft-deprecated the version, and will raise this only when a true deprecation is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The PostgreSQL Global Development Group supports a major version for 5 years after its initial release. After this, a final minor version will be released and the software will then be unsupported (end-of-life).
(For version 13) This will be on November 13, 2025." https://www.postgresql.org/support/versioning/