Added some missing change log #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbourigault
approved these changes
Nov 29, 2017
|
Excellent and dev test passes with sf4 |
dbu
reviewed
Nov 30, 2017
|
|
||
| ### Changed | ||
|
|
||
| - `ProfilePlugin` and `StackPlugin` are no longer registered as (private) services decorators. Those decorators are now | ||
| created through the `Http\HttplugBundle\Collector\PluginClientFactory`. | ||
| - `PluginClient` is not used for discovered clients. |
There was a problem hiding this comment.
this is more confusing than helpful, i think. we should either consider this an internal detail or explain a bit what it means.
dbu
reviewed
Nov 30, 2017
| - Any third party library using `Http\Client\Common\PluginClientFactory` to create `Http\Client\Common\PluginClient` | ||
| instances now gets zero config profiling. | ||
| - `Http\Client\Common\PluginClientFactory` factory service. | ||
| - Add missing service reference for `cache_key_generator` |
There was a problem hiding this comment.
i think this is a bugfix. its to make a configuration option that existed but was not working actually work as expected. ok if i move it and make it more explicit?
There was a problem hiding this comment.
oh, its already in the list of bugfixes for this version. i will remove this line.
|
see #233 where i try to implement my feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.