improve changelog #233
Merged
improve changelog #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Nov 30, 2017
xabbuh
reviewed
Nov 30, 2017
CHANGELOG.md
Outdated
| @@ -6,26 +6,25 @@ The change log describes what is "Added", "Removed", "Changed" or "Fixed" betwee | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Service for`Http\Client\Common\PluginClientFactory`. | |||
| - Symfony 4 support. | |||
| - Service for`Http\Client\Common\PluginClientFactory` to allow autowiring. | |||
There was a problem hiding this comment.
Support autowiring of Http\Client\Common\PluginClientFactory?
There was a problem hiding this comment.
but anyway, there is a space missing after "for"
dbu
force-pushed
the
update-changelog
branch
from
2aa122f to
c905dbc
Compare
|
i don't want to duplicate the class name. better like this? |
dbu
force-pushed
the
update-changelog
branch
from
c905dbc to
3ba4f90
Compare
xabbuh
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make changelog more clear to read for users