Skip to content

Update branch alias #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Update branch alias #315

merged 2 commits into from
Jul 22, 2019

Conversation

XWB
Copy link
Contributor

@XWB XWB commented Jul 1, 2019

No description provided.

@@ -56,7 +56,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "0.7-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, isn't it should be 0.9-dev since we already have 0.8 releases?

Btw, could you explain where it can be useful? I don't understand its purpose at all :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether branch-alias actually is needed, as the repo has tags already?

https://getcomposer.org/doc/articles/aliases.md#branch-alias

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bocharsky-bw Unless the next release is 0.8.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvanlaak It allows to install the latest changes for a given development version, like this:

"php-translation/symfony-bundle": "^0.8@dev"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why not just: "php-translation/symfony-bundle": "dev-master"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"php-translation/symfony-bundle": "dev-master" will always fetch the latest. If you do "php-translation/symfony-bundle": "^0.8@dev" you will get 0.8 (or dev 0.8) but never 0.9.

We should update branch alias to 0.9 now since it will be the next version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation 👍

I just updated it to 0.9

@XWB XWB requested a review from Nyholm July 3, 2019 16:32
@bobdenotter
Copy link
Contributor

Should this PR include an update to the following line?

"symfony/translation": "^2.7 || ^3.0 || ^4.0,<4.2",

Currently, using "^0.8@dev" or "dev-master" will fail on an SF 4.3 install:

$ composer update    
Loading composer repositories with package information
Updating dependencies (including require-dev)
Restricting packages listed in "symfony/symfony" to "^4.3"
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for php-translation/symfony-bundle dev-master -> satisfiable by php-translation/symfony-bundle[dev-master].
    - php-translation/symfony-bundle dev-master requires symfony/translation ^2.7 || ^3.0 || ^4.0,<4.2 -> no matching package found.

@bocharsky-bw
Copy link
Member

Should this PR include an update to the following line?
"symfony/translation": "^2.7 || ^3.0 || ^4.0,<4.2",

I think it should not, otherwise, tests will fail here. This bundle is not quite compatible with Sf 4.2/4.3 yet :/ Probably if we want to allow Sf 4.2 / 4.3 - we should make it compatible and fix tests

@Nyholm
Copy link
Member

Nyholm commented Jul 22, 2019

The only thing needed for translation 4.3 support is a fix in ReplaceOperation. I tried to work on that but failed, I will try another attempt later. (We have tests, feel free to try yourself =) )

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit b2921af into php-translation:master Jul 22, 2019
@welcoMattic
Copy link
Member

I'll try may be this week, if I found enough spare time ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants