-
Notifications
You must be signed in to change notification settings - Fork 93
Update branch alias #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update branch alias #315
Conversation
@@ -56,7 +56,7 @@ | |||
}, | |||
"extra": { | |||
"branch-alias": { | |||
"dev-master": "0.7-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, isn't it should be 0.9-dev
since we already have 0.8
releases?
Btw, could you explain where it can be useful? I don't understand its purpose at all :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether branch-alias
actually is needed, as the repo has tags already?
https://getcomposer.org/doc/articles/aliases.md#branch-alias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bocharsky-bw Unless the next release is 0.8.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvanlaak It allows to install the latest changes for a given development version, like this:
"php-translation/symfony-bundle": "^0.8@dev"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why not just: "php-translation/symfony-bundle": "dev-master"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"php-translation/symfony-bundle": "dev-master" will always fetch the latest. If you do "php-translation/symfony-bundle": "^0.8@dev" you will get 0.8 (or dev 0.8) but never 0.9.
We should update branch alias to 0.9 now since it will be the next version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation 👍
I just updated it to 0.9
Should this PR include an update to the following line?
Currently, using
|
I think it should not, otherwise, tests will fail here. This bundle is not quite compatible with Sf 4.2/4.3 yet :/ Probably if we want to allow Sf 4.2 / 4.3 - we should make it compatible and fix tests |
The only thing needed for translation 4.3 support is a fix in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
I'll try may be this week, if I found enough spare time ;) |
No description provided.