Skip to content

Update branch alias #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Update branch alias #315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f073f0
Update branch alias
XWB Jul 1, 2019
f7d203d
Update branch alias to 0.9-dev
bocharsky-bw Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "0.7-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, isn't it should be 0.9-dev since we already have 0.8 releases?

Btw, could you explain where it can be useful? I don't understand its purpose at all :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether branch-alias actually is needed, as the repo has tags already?

https://getcomposer.org/doc/articles/aliases.md#branch-alias

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bocharsky-bw Unless the next release is 0.8.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvanlaak It allows to install the latest changes for a given development version, like this:

"php-translation/symfony-bundle": "^0.8@dev"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why not just: "php-translation/symfony-bundle": "dev-master"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"php-translation/symfony-bundle": "dev-master" will always fetch the latest. If you do "php-translation/symfony-bundle": "^0.8@dev" you will get 0.8 (or dev 0.8) but never 0.9.

We should update branch alias to 0.9 now since it will be the next version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation 👍

I just updated it to 0.9

"dev-master": "0.9-dev"
}
}
}