Skip to content

Added twig as a dependency #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Added twig as a dependency #329

merged 1 commit into from
Sep 5, 2019

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Sep 5, 2019

Im not sure why we limited the versions in #313. But removing a direct dependency in #324 is not a good solution.

I've added back twig/twig with their latest 1.x and 2.x versions.

@XWB XWB merged commit eb40897 into php-translation:master Sep 5, 2019
@Nyholm Nyholm deleted the twig-deps branch September 5, 2019 14:54
@bocharsky-bw
Copy link
Member

@Nyholm Hm, I removed twig/twig in #324 because we also require symfony/twig-bundle which in turn requires twig/twig. I still don't see a value in having twig/twig unless we want to explicitly exclude some Twig versions. Wdyt? //cc @XWB

@Nyholm
Copy link
Member Author

Nyholm commented Sep 5, 2019 via email

@bocharsky-bw
Copy link
Member

Now I see, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants