An attempt to make all tests green again so we can moving forward and merge PRs #313
Conversation
bocharsky-bw
changed the title
bocharsky-bw
changed the title
|
Guys, here's an attempt to fix the tests - we had all of them broken lately. Would be glad to any feedback because some important changes were made here and looking forward bring back all tests green soon so that we can continue merging new PRs and releasing new versions //cc @Nyholm |
|
Awesome work btw. |
|
Thanks!
Sounds like a good plan 👍 |
| @@ -13,18 +13,19 @@ | |||
| "php": "^5.5 || ^7.0", | |||
| "symfony/framework-bundle": "^2.7 || ^3.0 || ^4.0", | |||
| "symfony/validator": "^2.7 || ^3.0 || ^4.0", | |||
| "symfony/translation": "^2.7 || ^3.0 || ^4.0", | |||
| "symfony/translation": "^2.7 || ^3.0 || ^4.0,<4.2", | |||
There was a problem hiding this comment.
I see your point, but at that time without a proper fix this was not so bad idea, it helped to push things forward in this bundle and merge many PRs awaiting green tests. Totally agree we should revert this change back, but also we should make tests green and properly fix the problem in this bundle on Sf 4.2+
There was a problem hiding this comment.
May be it's time to fix it? I think we have make tests green in #323 with help of @nicolas-grekas because it's apparently a BC break introduced with 4.2+ version of Symfony
| "symfony/twig-bundle": "^2.7 || ^3.0 || ^4.0", | ||
| "symfony/finder": "^2.7 || ^3.0 || ^4.0", | ||
| "symfony/intl": "^2.7 || ^3.0 || ^4.0", | ||
|
|
||
| "php-translation/common": "^1.0", | ||
| "php-translation/symfony-storage": "^1.0", | ||
| "php-translation/extractor": "^1.3", | ||
| "nyholm/nsa": "^1.1" | ||
| "nyholm/nsa": "^1.1", | ||
| "twig/twig": "<1.39 || ^2.0,<2.8" |
There was a problem hiding this comment.
Same really bad idea. This is opting out from any maintenance efforts and preventing users to upgrade.
There was a problem hiding this comment.
Agree, reverted in #324 - most probably tests will fail so we will need to fix them before merging
The current version of this bundle does not work with Symfony 4.2 well due to the new Intl formatter, that's why some tests failed. Other tests failed due to BC breaks and deprecations. Probably we should downgrade Sf Translation component version to
<4.2before a proper fix to avoid BC breaks. Also, let's do not force failing builds on deprecation notices since this bundle is not actively developed lately - it causes more problems. Also, not sure, but it seems like TravisCI just dropped PHP 5.5 support, so I had to use PHP 5.6 as lowest PHP version