Skip to content

chore(travis): disable Composer's memory limit #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2019
Merged

chore(travis): disable Composer's memory limit #291

merged 2 commits into from
Jun 25, 2019

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Mar 13, 2019 •
edited
Loading

Some tests are passing again, but other fails because:

  • Twig deprecations since v2.7.0 released tomorrow, that makes PHPUnit exit with status code different from 0
  • Sometimes, PHPUnit can't be downloaded from GitHub releases: PHP Warning: fopen(https://github.com/sebastianbergmann/phpunit/archive/5.7.zip): failed to open stream: HTTP request failed! HTTP/1.0 404 Not Found in /home/travis/build/php-translation/symfony-bundle/vendor/symfony/phpunit-bridge/bin/simple-phpunit on line 62 🤷‍♂️

Diff:
master branch:
Capture d'écran de 2019-03-13 07-41-35

this branch:
Capture d'écran de 2019-03-13 07-41-39

@Kocal Kocal mentioned this pull request Mar 13, 2019
Merged
@bocharsky-bw
Copy link
Member

Do you have an example (link) where we have memory_limit problem? As I see in this PR COMPOSER_MEMORY_LIMIT does not help much with broken tests :/

@Kocal
Copy link
Contributor Author

Kocal commented Apr 12, 2019 •
edited
Loading

Yes, these ones from #290 for example:

The same builds on this PR:

For the other broken tests, as said in first post, it's because of Twig deprecations (which are fixed in #290):

And sometimes it's related to operations on catalogues:

bocharsky-bw
bocharsky-bw approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense then 👍

Thank you for providing more info on it

@Kocal
Copy link
Contributor Author

Kocal commented Apr 12, 2019

My bad, I should have done it before! :)

@bocharsky-bw bocharsky-bw mentioned this pull request Apr 15, 2019
Closed
@bocharsky-bw
Copy link
Member

Thank you @Kocal , I reused your solution in #313 so just merging this to give you a credit

@bocharsky-bw bocharsky-bw merged commit c6aa0cf into php-translation:master Jun 25, 2019
@Kocal Kocal deleted the chore/trying-to-fix-travis branch June 25, 2019 07:22
@Kocal
Copy link
Contributor Author

Kocal commented Jun 25, 2019

Nice! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanlaak rvanlaak rvanlaak approved these changes

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kocal @bocharsky-bw @rvanlaak