-
Notifications
You must be signed in to change notification settings - Fork 93
chore(twig): replace class aliases by class namespaces #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(twig): replace class aliases by class namespaces #290
Conversation
Would be great if this could get merged. Twig namespaces are already introduced in Twig 1.x, so I do not believe any problems would come with these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry, we don't have those issues anymore since twigphp/Twig#2887 was quickly merged and released after twigphp/Twig#2863. 👍 |
Hm, I think we need to double check in what version those namespaces were introduced and bump Twig minimum constraint in |
It makes sens, namespace classes as default classes have been introduced in Twig 2.7.0 and Twig 1.38.0. But I don't know how I should modifiy the |
Thank you for providing more information about it! I bumped Twig version in 8cf4938 - now tests should pass. I think I'm fine with using namespaces but would like to hear more opinions on it. |
Oh, This PR looks great. I will rebase it and merge it when tests are green. |
b508c40
to
20c41c0
Compare
It's a following of #288 (comment), since Twig 3 will remove non-namespaced classes.
EDIT: hum, there is a lot of Travis builds that fail:
new_c
andold_d
(which appears on other PRs too) :(