Skip to content

Do not force minimum stabilty anymore #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

odolbeau
Copy link
Member

Not needed as extractor 2.0 have been released.

@Nyholm
Copy link
Member

Nyholm commented Dec 26, 2019

Removing this line have no effect. The same packages will still be installed. With this line though, we may use the "branch alias", if other libraries define those.

I added this because I wanted to make sure we ran tests with extractor:dev-master. Thanks to the branch alias of extractor lib we could type php-translation/extractor: ^2.0 and still get dev master. (And we would also be sure not to get version 3).

Now when version 2.0 is released, it will use stable versions since we have --prefer-stable in .travis.yml.


That said, I dont mind removing this and adding it back when we want to test the bundle with unreleased versions of other libraries.

@odolbeau
Copy link
Member Author

I removed it because if you don't use the --prefer-stable option, composer will download the master version of all packages.
As it doesn't have any impact on end users, I don't mind if we keep the composer.json file as is.

@rvanlaak
Copy link
Member

These properties are root-only properties, so only will have effect when we are working on the package.

In other words, as we are trying to support as many versions of our dependencies as we agree on these safely can get removed 👍

https://getcomposer.org/doc/04-schema.md#minimum-stability

@odolbeau odolbeau closed this Jan 2, 2020
@odolbeau odolbeau deleted the minimum-stability branch January 2, 2020 08:40
@odolbeau odolbeau mentioned this pull request Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants