Skip to content

Update docker image used in github actions #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2020

Conversation

odolbeau
Copy link
Member

No description provided.

@odolbeau
Copy link
Member Author

@rvanlaak See #374 before merging this please.

@rvanlaak
Copy link
Member

rvanlaak commented Jan 2, 2020

Imho we could have merged #367 , or add --prefer-stable to fix #374 (comment)

@odolbeau
Copy link
Member Author

odolbeau commented Jan 2, 2020

Not merging #367 make sense and I saw a few repos which have this flag (SensioFrameworkExtraBundle for example https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/composer.json#L46)

Where can we add the prefer-stable option?

@odolbeau odolbeau force-pushed the update-github-actions branch from 38193e4 to 1b43937 Compare January 2, 2020 08:48
@rvanlaak
Copy link
Member

rvanlaak commented Jan 2, 2020

Did push scribbr@5196800 for that. Shall I create a PR for you? You could also cherry-pick it here?

@odolbeau
Copy link
Member Author

odolbeau commented Jan 2, 2020

Looks good for me, don't hesitate to create a PR. :)

@rvanlaak
Copy link
Member

rvanlaak commented Jan 2, 2020

@odolbeau let's see if #376 passes

@Nyholm
Copy link
Member

Nyholm commented Jan 6, 2020

Thank you

@Nyholm Nyholm merged commit edf17ea into php-translation:master Jan 6, 2020
@odolbeau odolbeau deleted the update-github-actions branch January 8, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants