Skip to content

Allow Symfony 6 #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Allow Symfony 6 #464

merged 2 commits into from
Jan 28, 2022

Conversation

bocharsky-bw
Copy link
Member

Closes #457

@bocharsky-bw bocharsky-bw mentioned this pull request Jan 27, 2022
},
"config": {
"allow-plugins": {
"bamarni/composer-bin-plugin": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What it this?

Copy link
Member Author

@bocharsky-bw bocharsky-bw Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, good question! Well, I see we use that bundle in deps list... and lately I start seeing this:

# composer update
bamarni/composer-bin-plugin contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
Do you trust "bamarni/composer-bin-plugin" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?]

And I just replied Y, and it added this config. Without this little config it will always ask that message on each composer update/install command run. Any idea what else can we do? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was introduced by @Nyholm in #429 while adding github actions, but I'm not sure either why it is needed. So, I'm fine with allowing it for now.

@bocharsky-bw
Copy link
Member Author

Thank you guys!

@bocharsky-bw bocharsky-bw merged commit b946f06 into php-translation:master Jan 28, 2022
@bocharsky-bw bocharsky-bw deleted the symfony6 branch January 28, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symfony 6 Support
3 participants