Skip to content

Allow Symfony 6 #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Allow Symfony 6 #464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a7d63a
Allow Symfony 6
bocharsky-bw Jan 27, 2022
2aa11a5
Allow 6.0 for missed symfony/phpunit-bridge too
bocharsky-bw Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,30 +11,30 @@
],
"require": {
"php": "^7.2 || ^8.0",
"symfony/framework-bundle": "^4.4.20 || ^5.2.5",
"symfony/validator": "^4.4.20 || ^5.2.5",
"symfony/translation": "^4.4.20 || ^5.2.5",
"symfony/twig-bundle": "^4.4.20 || ^5.2.4",
"symfony/finder": "^4.4.20 || ^5.2.4",
"symfony/intl": "^4.4.20 || ^5.2.4",
"symfony/framework-bundle": "^4.4.20 || ^5.2.5 || ^6.0",
"symfony/validator": "^4.4.20 || ^5.2.5 || ^6.0",
"symfony/translation": "^4.4.20 || ^5.2.5 || ^6.0",
"symfony/twig-bundle": "^4.4.20 || ^5.2.4 || ^6.0",
"symfony/finder": "^4.4.20 || ^5.2.4 || ^6.0",
"symfony/intl": "^4.4.20 || ^5.2.4 || ^6.0",

"php-translation/symfony-storage": "^2.1",
"php-translation/extractor": "^2.0",
"nyholm/nsa": "^1.1",
"twig/twig": "^2.14.4 || ^3.3",
"symfony/asset": "^4.4.20 || ^5.2.4"
"symfony/asset": "^4.4.20 || ^5.2.4 || ^6.0"
},
"require-dev": {
"symfony/phpunit-bridge": "^5.2",
"symfony/phpunit-bridge": "^5.2 || ^6.0",
"bamarni/composer-bin-plugin": "^1.3",
"php-translation/translator": "^1.0",
"php-http/curl-client": "^1.7 || ^2.0",
"php-http/message": "^1.11",
"php-http/message-factory": "^1.0.2",
"symfony/console": "^4.4.20 || ^5.2.5",
"symfony/twig-bridge": "^4.4.20 || ^5.2.5",
"symfony/dependency-injection": "^4.4.20 || ^5.2.5",
"symfony/web-profiler-bundle": "^4.4.20 || ^5.2.4",
"symfony/console": "^4.4.20 || ^5.2.5 || ^6.0",
"symfony/twig-bridge": "^4.4.20 || ^5.2.5 || ^6.0",
"symfony/dependency-injection": "^4.4.20 || ^5.2.5 || ^6.0",
"symfony/web-profiler-bundle": "^4.4.20 || ^5.2.4 || ^6.0",
"matthiasnoback/symfony-dependency-injection-test": "^4.1",
"matthiasnoback/symfony-config-test": "^4.1",
"nyholm/psr7": "^1.1",
Expand All @@ -59,5 +59,10 @@
"branch-alias": {
"dev-master": "0.12-dev"
}
},
"config": {
"allow-plugins": {
"bamarni/composer-bin-plugin": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What it this?

Copy link
Member Author

@bocharsky-bw bocharsky-bw Jan 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, good question! Well, I see we use that bundle in deps list... and lately I start seeing this:

# composer update
bamarni/composer-bin-plugin contains a Composer plugin which is currently not in your allow-plugins config. See https://getcomposer.org/allow-plugins
Do you trust "bamarni/composer-bin-plugin" to execute code and wish to enable it now? (writes "allow-plugins" to composer.json) [y,n,d,?]

And I just replied Y, and it added this config. Without this little config it will always ask that message on each composer update/install command run. Any idea what else can we do? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was introduced by @Nyholm in #429 while adding github actions, but I'm not sure either why it is needed. So, I'm fine with allowing it for now.

}
}
}