Add php-cs-fixer as github action #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odolbeau
commented
Dec 6, 2019
odolbeau
commented
Dec 6, 2019
| */ | ||
| public static function contentToCatalogue($content, $locale, $domain) | ||
| public static function contentToCatalogue(string $content, string $locale, string $domain): MessageCatalogue |
There was a problem hiding this comment.
This change is a BC break. It's not a real problem as we're about to release a new major version anyway.
rvanlaak
approved these changes
Dec 6, 2019
odolbeau
force-pushed
the
php-cs-fixer
branch
2 times, most recently
from
945c07e to
dc6dd5a
Compare
odolbeau
force-pushed
the
php-cs-fixer
branch
3 times, most recently
from
3c762c1 to
094acdd
Compare
3 tasks
odolbeau
force-pushed
the
php-cs-fixer
branch
from
094acdd to
6d11229
Compare
odolbeau
force-pushed
the
php-cs-fixer
branch
2 times, most recently
from
5a7424c to
2d7f883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked (& heavily inspired by) #38
@rvanlaak I'll wait for your PR to be merged otherwise you'll have a bunch of conflicts to resolve...