SF 5.x compatibility #356
SF 5.x compatibility #356
Conversation
| @@ -132,7 +132,7 @@ private function convertSourceLocationsToMessages(MessageCatalogue $catalogue, S | |||
| } | |||
|
|
|||
| $key = $sourceLocation->getMessage(); | |||
| $catalogue->set($key, null, $domain); | |||
There was a problem hiding this comment.
According to the interface, second parameter must be a string.
Fortunately, the default MessageCatalogue call the add method which is also declared in the interface.
| @@ -69,11 +70,19 @@ public function testExecute(): void | |||
| $container = $this->getContainer(); | |||
| $application->add($container->get('php_translator.console.extract')); | |||
|
|
|||
| // transchoice tag have been definively removed in sf ^5.0 | |||
| // Remove this condition & views_with_transchoice + associated config once sf ^5.0 is the minimum supported version. | |||
| if (\version_compare(Kernel::VERSION, 5.0, '<')) { | |||
There was a problem hiding this comment.
Might not be the best idea to rely on the Kernel to retrieve the Symfony version but as it's in tests, I think it does the job pretty well.
| "phpunit/phpunit": "^8.4" | ||
| }, | ||
| "conflict": { | ||
| "symfony/config": "<3.4.31" |
There was a problem hiding this comment.
We need a fix released in symfony/config v3.4.31
I didn't spend time to determine which fix we need but I guess it's this one symfony/config@5d1036e
Otherwise we have failing tests: https://travis-ci.org/php-translation/symfony-bundle/jobs/622045567?utm_medium=notification&utm_source=github_status
Diff between v3.4.30 & v3.4.31 here: symfony/config@v3.4.30...v3.4.31
|
(I will remember your todos) |
Linked to #345 which is blocked since a few days.
Contains :
kernel.root_dirTODO before releasing a new major version of this bundle:
php-translation/extractorto^2.0once releasedphp-translation/symfony-storageto^2.0once released