feat(react): add useQuery and useStatus hooks #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chriztiaan
reviewed
Apr 25, 2024
Chriztiaan
reviewed
Apr 29, 2024
Chriztiaan
reviewed
Apr 29, 2024
Chriztiaan
previously approved these changes
Apr 29, 2024
benitav
reviewed
Apr 29, 2024
rkistner
reviewed
Apr 29, 2024
stevensJourney
approved these changes
Apr 30, 2024
rkistner
reviewed
Apr 30, 2024
There was a problem hiding this comment.
There are some issues when the query (or parameters) change:
- The query is not refreshed until another change notification is triggered.
- The watched table list is never not updated.
This is specifically noticeable on the "SQL Console" page of the react-supabase-todolist demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement new hooks
Work Done
useQueryhookuseStatushookusePowersyncWatchedQuery,usePowerSyncQueryandusePowerSyncStatushooksHow to test
Note: The suspense and kysely hook changes will follow after this, and I will make a separate change for the Vue hooks so that they conform to this new change