Starter Task 2: Adding return type annotation to the _attribute_progress_setup method #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D75972827 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
…ess_setup method (pytorch#1576) Summary: The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Differential Revision: D75972827
ArjunR2404
force-pushed
the
export-D75972827
branch
from
a9d2a71 to
752fc1d
Compare
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
…ess_setup method (pytorch#1576) Summary: The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Differential Revision: D75972827
|
This pull request was exported from Phabricator. Differential Revision: D75972827 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
…ess_setup method (pytorch#1576) Summary: Pull Request resolved: pytorch#1576 The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Differential Revision: D75972827
ArjunR2404
force-pushed
the
export-D75972827
branch
from
752fc1d to
9e2ff6e
Compare
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
…ess_setup method (pytorch#1576) Summary: Pull Request resolved: pytorch#1576 The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Differential Revision: D75972827
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
…ess_setup method (pytorch#1576) Summary: The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
…ess_setup method (pytorch#1576) Summary: The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
…ess_setup method (pytorch#1576) Summary: The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
ArjunR2404
force-pushed
the
export-D75972827
branch
from
9e2ff6e to
f5aa3b1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75972827 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
…ess_setup method (pytorch#1576) Summary: Pull Request resolved: pytorch#1576 The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
ArjunR2404
force-pushed
the
export-D75972827
branch
from
f5aa3b1 to
9fd524b
Compare
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 4, 2025
…ess_setup method (pytorch#1576) Summary: Pull Request resolved: pytorch#1576 The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Differential Revision: D75972827
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
…ess_setup method (pytorch#1576) Summary: The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
ArjunR2404
force-pushed
the
export-D75972827
branch
from
9fd524b to
ffff5fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75972827 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
…ess_setup method (pytorch#1576) Summary: Pull Request resolved: pytorch#1576 The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
ArjunR2404
force-pushed
the
export-D75972827
branch
from
ffff5fc to
746b3dd
Compare
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
…ess_setup method (pytorch#1576) Summary: The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
ArjunR2404
force-pushed
the
export-D75972827
branch
from
746b3dd to
033f105
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75972827 |
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
…ess_setup method (pytorch#1576) Summary: Pull Request resolved: pytorch#1576 The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
ArjunR2404
force-pushed
the
export-D75972827
branch
from
033f105 to
c91a202
Compare
Summary: Pull Request resolved: pytorch#1575 My task was to remove the redundant progress bar code now that tqdm is a dependency. The problem was that since tqdm is now a dependency, we don't need to make checks for whether or not tqdm is being used, and thus we can remove the simple progress print code in the progress function (as well as the import error try-except code at the very top of the file). I also removed the SimpleProgress class definition, as well as the use_tqdm parameter in the progress function. Since we are no longer using the SimpleProgress object anywhere, I removed it from wherever it was used in the codebase (feature_ablation.py). In the test_progress.py, I removed the tests corresponding to SimpleProgress. Differential Revision: D75814260 Reviewed By: cyrjano
ArjunR2404
added a commit
to ArjunR2404/captum
that referenced
this pull request
Jun 5, 2025
…ess_setup method (pytorch#1576) Summary: The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
ArjunR2404
force-pushed
the
export-D75972827
branch
from
c91a202 to
2e50627
Compare
…ess_setup method (pytorch#1576) Summary: Pull Request resolved: pytorch#1576 The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function. Reviewed By: sarahtranfb Differential Revision: D75972827
|
This pull request was exported from Phabricator. Differential Revision: D75972827 |
ArjunR2404
force-pushed
the
export-D75972827
branch
from
2e50627 to
2d932b8
Compare
|
This pull request has been merged in 3d6765a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The problem was that the _attribute_progress_setup method in feature_ablation.py didn't have a return type annotation. After making the relevant changes in the task 1 diff to only have the progress function return a tqdm object, I added a tqdm return type annotation to the _attribute_progress_setup function.
Differential Revision: D75972827