Skip to content

bumping js-slang #3108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2025
Merged

bumping js-slang #3108

merged 2 commits into from
Mar 5, 2025

Conversation

martin-henz
Copy link
Member

test cases need fixing: lazy and gpu variants are removed in the newest js-slang

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update other dependencies and CI workflow as well due to js-slang changes

@sayomaki sayomaki mentioned this pull request Mar 5, 2025
6 tasks
Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should work after #3109 is merged.

@RichDom2185
Copy link
Member

LGTM, should work after #3109 is merged.

Let's remove gpu JS from CI since JS-slang doesn't need it anymore

@sayomaki sayomaki reopened this Mar 5, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13667710527

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.132%

Totals Coverage Status
Change from base Build 13667704397: 0.0%
Covered Lines: 4887
Relevant Lines: 14806

💛 - Coveralls

@martin-henz martin-henz merged commit da82779 into master Mar 5, 2025
8 checks passed
@martin-henz martin-henz deleted the 1081 branch March 5, 2025 03:23
@RichDom2185
Copy link
Member

@martin-henz hi Prof, actually it was still not handled yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants