Skip to content

Remove lazy and GPU variants #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 5, 2025
Merged

Remove lazy and GPU variants #3109

merged 4 commits into from
Mar 5, 2025

Conversation

sayomaki
Copy link
Contributor

@sayomaki sayomaki commented Mar 5, 2025

Description

Removes the lazy and GPU variants that are no longer provided in the latest version of js-slang. Resolves #3108

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code

@sayomaki sayomaki requested a review from RichDom2185 March 5, 2025 03:10
@sayomaki sayomaki self-assigned this Mar 5, 2025
RichDom2185
RichDom2185 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) March 5, 2025 03:12
@sayomaki sayomaki mentioned this pull request Mar 5, 2025
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13667652740

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 31.132%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 13630891198: -0.004%
Covered Lines: 4887
Relevant Lines: 14806
💛 - Coveralls

@RichDom2185 RichDom2185 merged commit 6cb15d5 into master Mar 5, 2025
8 checks passed
@RichDom2185 RichDom2185 deleted the remove-lazy-gpu branch March 5, 2025 03:14
martin-henz
martin-henz approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees

@sayomaki sayomaki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayomaki @coveralls @martin-henz @RichDom2185