Skip to content

Part 2: Update the struct definitions to match version 3.14 of the LSP spec #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 13, 2019
Merged

Part 2: Update the struct definitions to match version 3.14 of the LSP spec #206

merged 5 commits into from
Dec 13, 2019

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Dec 5, 2019

Part 2 of #202.

@ahoppen ahoppen requested a review from benlangmuir as a code owner December 5, 2019 01:47
@ahoppen ahoppen mentioned this pull request Dec 5, 2019
Merged
@ahoppen ahoppen force-pushed the match-spec-part-2 branch 2 times, most recently from b8b544a to 41e03bd Compare December 6, 2019 23:30
@ahoppen
Copy link
Member Author

ahoppen commented Dec 6, 2019

@swift-ci Please test

2 similar comments
@ahoppen
Copy link
Member Author

ahoppen commented Dec 9, 2019

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Dec 10, 2019

@swift-ci Please test

benlangmuir
benlangmuir reviewed Dec 11, 2019
View reviewed changes
Sources/LanguageServerProtocol/ServerCapabilities.swift Outdated

public enum TextDocumentSyncOptionsWrapper: Codable, Hashable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we decode sync kind to be TextDocumentSyncOptions with all other fields nil?

@ahoppen
Copy link
Member Author

ahoppen commented Dec 13, 2019

Thanks for the review.

I updated TextDocumentSyncOptions to decode the sync kind with all other parameters set to nil and generated a linux main.

@swift-ci Please test

@ahoppen ahoppen mentioned this pull request Dec 13, 2019
Merged
@ahoppen
Copy link
Member Author

ahoppen commented Dec 13, 2019

@swift-ci Please test

@benlangmuir benlangmuir merged commit 79e312b into swiftlang:master Dec 13, 2019
@ahoppen ahoppen mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @benlangmuir