Skip to content

Commit d305f59

Browse files
authored
Revert portion of workaround landed in #1139 which disabled the mandatory perf optimization pass (#1172)
This reverts most of the workaround I landed in #1139. A compiler fix in swiftlang/swift#82034 has resolved the problem that necessitated it, and our macOS CI is using a new-enough toolchain which has that fix. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
1 parent 3ee5ec0 commit d305f59

File tree

1 file changed

+2
-16
lines changed

1 file changed

+2
-16
lines changed

Package.swift

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ let package = Package(
129129
"_Testing_Foundation",
130130
"MemorySafeTestingTests",
131131
],
132-
swiftSettings: .packageSettings + .disableMandatoryOptimizationsSettings
132+
swiftSettings: .packageSettings
133133
),
134134

135135
// Use a plain `.target` instead of a `.testTarget` to avoid the unnecessary
@@ -234,7 +234,7 @@ package.targets.append(contentsOf: [
234234
"Testing",
235235
"TestingMacros",
236236
],
237-
swiftSettings: .packageSettings + .disableMandatoryOptimizationsSettings
237+
swiftSettings: .packageSettings
238238
)
239239
])
240240
#endif
@@ -397,20 +397,6 @@ extension Array where Element == PackageDescription.SwiftSetting {
397397
[]
398398
#endif
399399
}
400-
401-
/// Settings which disable Swift's mandatory optimizations pass.
402-
///
403-
/// This is intended only to work around a build failure caused by a Swift
404-
/// compiler regression which is expected to be resolved in
405-
/// [swiftlang/swift#82034](https://github.com/swiftlang/swift/pull/82034).
406-
///
407-
/// @Comment {
408-
/// - Bug: This should be removed once the CI issue is resolved.
409-
/// [swiftlang/swift-testin#1138](https://github.com/swiftlang/swift-testing/issues/1138).
410-
/// }
411-
static var disableMandatoryOptimizationsSettings: Self {
412-
[.unsafeFlags(["-Xllvm", "-sil-disable-pass=mandatory-performance-optimizations"])]
413-
}
414400
}
415401

416402
extension Array where Element == PackageDescription.CXXSetting {

0 commit comments

Comments
 (0)