Revert portion of workaround landed in #1139 which disabled the mandatory perf optimization pass #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tlang#1139)" This reverts commit 603a568.
stmontgomery
requested review from
grynspan,
briancroom and
suzannaratcliff
as code owners
stmontgomery
added
enhancement
|
@swift-ci please test |
|
CI results indicate the failure is still occurring, so need to investigate further. |
…e there appears to be some new regression in compile-time constant detection
|
@swift-ci please test |
stmontgomery
changed the title
grynspan
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts most of the workaround I landed in #1139. A compiler fix in swiftlang/swift#82034 has resolved the problem that necessitated it, and our macOS CI is using a new-enough toolchain which has that fix.
Checklist: