Skip to content

[Demangle] Implement missing `Node::Kind::OutlinedInitializeWithTakeN… #82034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jun 5, 2025

…oValueWitness`

Implements de/remangler support for WOB manglings.

@xedin xedin requested review from rjmccall and eeckstein as code owners June 5, 2025 21:00
@xedin
Copy link
Contributor Author

xedin commented Jun 5, 2025

@swift-ci please build toolchain macOS platform

@xedin
Copy link
Contributor Author

xedin commented Jun 5, 2025

@eeckstein I couldn't come up with a reduction for this based on swift-testing failure in swiftlang/swift-testing#1136

It should be something like this:

public protocol P {
}

public protocol Q : P {
}

public protocol W : P {
}

public enum Node : W {
    case test(a: String, b: String)
}

public func repro(node: Node) {
    if let x = node as? any Q { print(x) }
}

But that generates WOb whatever I do...

…oValueWitness`

Implements de/remangler support for `WOB` manglings.
@xedin xedin force-pushed the rdar-152665294 branch from 2e6a085 to 8e49860 Compare June 5, 2025 21:07
@xedin
Copy link
Contributor Author

xedin commented Jun 5, 2025

@swift-ci please build toolchain macOS platform

@xedin
Copy link
Contributor Author

xedin commented Jun 5, 2025

@swift-ci please build toolchain macOS platform

@xedin
Copy link
Contributor Author

xedin commented Jun 6, 2025

@swift-ci please test

@xedin xedin requested a review from hborla as a code owner June 6, 2025 05:28
@xedin xedin force-pushed the rdar-152665294 branch from 81f919f to 8e49860 Compare June 6, 2025 05:30
@xedin xedin merged commit f5b30b0 into swiftlang:main Jun 6, 2025
5 of 6 checks passed
stmontgomery added a commit to swiftlang/swift-testing that referenced this pull request Jun 6, 2025
This applies a workaround to fix macOS builds (including CI) which began
failing due to a Swift compiler regression which is expected to be
resolved by swiftlang/swift#82034.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants