Correction and consistency improvement #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
phanan
reviewed
Oct 27, 2016
| @@ -10,15 +10,15 @@ The route object can be found in multiple places: | |||
|
|
|||
| - As the return value of calling `router.match(location)`; | |||
|
|
|||
| - Inside navigation guards as the first argument: | |||
| - Inside navigation guards as the first and second argument: | |||
There was a problem hiding this comment.
Shouldn't it be arguments (plural)?
There was a problem hiding this comment.
I think you're right. I'll raise another PR to correct this.
There was a problem hiding this comment.
Well I guess it should be as the first two arguments.
https://www.quora.com/Which-one-is-grammatically-correct-The-first-and-the-second-chapter-is-very-difficult-or-The-first-and-second-chapters-are-very-difficult
There was a problem hiding this comment.
I think that is more a matter of preference, as I think both are correct. Since you're a vuejs member, I'll change it to your preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.