Skip to content

Correction and consistency improvement #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2016
Merged

Correction and consistency improvement #834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/en/api/route-object.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ The route object can be found in multiple places:

- As the return value of calling `router.match(location)`;

- Inside navigation guards as the first argument:
- Inside navigation guards as the first and second argument:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be arguments (plural)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. I'll raise another PR to correct this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#842

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I guess it should be as the first two arguments.
https://www.quora.com/Which-one-is-grammatically-correct-The-first-and-the-second-chapter-is-very-difficult-or-The-first-and-second-chapters-are-very-difficult

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is more a matter of preference, as I think both are correct. Since you're a vuejs member, I'll change it to your preference.


``` js
router.beforeEach((to, from, next) => {
// to and from are both route objects
})
```

- Inside the `scrollBehavior` function as arguments:
- Inside the `scrollBehavior` function as the first and second argument:

``` js
const router = new VueRouter({
Expand Down