-
Notifications
You must be signed in to change notification settings - Fork 310
Welcome dialog on upgrade from legacy app #1590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0cefba9
to
8fb073a
Compare
I've pushed a revision that adjusts what URL the link goes to: static const String _announcementUrl =
// TODO(#1580) switch to this URL, which will point to the actual blog post:
// 'https://blog.zulip.com/flutter-mobile-app-launch';
// For the moment, that's a 404, so point directly to this pre-announcement:
'https://chat.zulip.org/#narrow/channel/1-announce/topic/New.20mobile.20app.20launching.20this.20week/near/2194879'; We'll want to change that before the actual launch, once the desired URL works. (Which will be before the actual post is up; it can redirect to that same pre-announcement instead, and change to redirecting to the post once the post is up.) |
CI failure in
Odd. And that's an uncommitted change, so left around by some previous step. Seems harmless in itself, so I'll ignore for now given the impending launch. If it recurs it'll be good to debug. |
And updated that URL; the desired URL works now 🙂 |
0952c06
to
63b2027
Compare
Well, that CI failure repeated the same way after my next few pushes after seeing it. But with the recent push which rebased this and its dependency #1588 past these commits in main: CI now passes 🤷. Of those, the two commits that touched any files in assets/l10n/ or lib/generated/l10n/ were: so presumably the reason involved one of those. |
LGTM, thanks, please merge at will! 🚀 |
Fixes #1580.
Stacked atop #1588.
I believe this works correctly. Some tests would be nice to write, but are less critical than for #1070 / #1588.
Screenshots