merge #3
Merged
merge #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation has been tested with the AS5048a PWM output. It follows an almost identical format to the existing MagneticSensorAnalog implementation.
adding MagneticSensorPWM implementation
Since there are no objections, and only the SAMD code is affected, I'm going to go ahead and merge this. Woohoo! SimpleFOC now supports SAMD51
fix compile problem on AVR due to SAMD header
Can be reverted when espressif/esp-idf#5429 is resolved.
random fixes related to current sensing
this is to use the enable pin on the DRV8316, which is actually a driver_off pin, and therefore active-low for enabled state
this enables two things: 1. you can still see the sensors change and update in SimpleFOCStudio even if you disable the motor. This is useful to determine sensor accuracy etc. 2. you previously ran the risk of losing track of full rotations if the motor was (e.g. manually) moved while disabled. With this change we always track the sensor values and keep track of all rotations.
Avoid the need for a custom header file for ESP32 compilation.
SAME51 support (tested on Feather M4 CAN) and minor tweaks
The eol character is now configurable The user can now actuvate echo feedback to see what he is typing I also removed a duplication in two run() overload, while fixing what I think was a mistake by enforcing the use of the provided argument Stream& even if the ctor one is not null. Lastly, I warn the user if \n is configured but \r is detected (only in user friendly mode) All the past code should work as before (no API change required)
I renamed the enum member EXTERN to EXTERNAL. For consistency, I also renmaed INTERN.
The solution is to define them based on the equivalent rp2040 constants
until I find a way to make it compatible, it is disabled when compling for rp2040. Problem is that SPIClass and SPISettings are not defined, SPI seems to work somewhat differently in rp2040
Issue #46: motor.command() and CRLF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.